<p><b>@jia200x</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10738#discussion_r246394858">pkg/wakaama/patches/0015-fixed-alignment-problem-in-lwm2m_data_t.patch</a>:</p>
<pre style='color:#555'>> +Date: Wed, 16 May 2018 11:30:02 +0200
+Subject: [PATCH] fixed alignment problem in lwm2m_data_t
+
+---
+ core/liblwm2m.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/core/liblwm2m.h b/core/liblwm2m.h
+index 3f16a6d..53616bf 100644
+--- a/core/liblwm2m.h
++++ b/core/liblwm2m.h
+@@ -299,7 +299,6 @@ typedef struct _lwm2m_data_t lwm2m_data_t;

+ struct _lwm2m_data_t
+ {
+-    lwm2m_data_type_t type;
</pre>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5888123" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/moenoel">@moenoel</a> is this safe? E.g wakaama code could eventually cast <code>_lwm2m_data_t</code> to <code>lwm2m_data_type_t</code> because address_of(_lwm2m_data_t) == addess_of(_lwm2m_data_t->type). With this change, address_of(_lwm2m_data_t) == address_of(_lwm2m_data_t->id).</p>
<p>Do you remember the reason behind this?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10738#pullrequestreview-190743248">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YM7CEwzO9chNaUZYM12w80nZY5Bbks5vBfjLgaJpZM4Z3ier">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YP_EdYQgzAfNUwENC2QZnESRkU4aks5vBfjLgaJpZM4Z3ier.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jia200x commented on #10738"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10738#pullrequestreview-190743248"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10738#pullrequestreview-190743248",
"url": "https://github.com/RIOT-OS/RIOT/pull/10738#pullrequestreview-190743248",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>