<p><b>@maribu</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10755#discussion_r248227124">tests/driver_ltc4150/main.c</a>:</p>
<pre style='color:#555'>> +static void spin(uint32_t seconds)
+{
+    uint32_t till = xtimer_now_usec() + US_PER_SEC * seconds;
+    while (xtimer_now_usec() < till) { }
+}
+
+/**
+ * @brief Thread that will put three levels of CPU load on the MCU
+ */
+static void *busy_thread(void *arg)
+{
+    (void)arg;
+    while (1) {
+        /* one minute of ~0% CPU usage */
+        LED0_OFF;
+        LED1_OFF;
</pre>
<p>True. But this wouldn't be a problem:</p>
<p><a href="https://github.com/RIOT-OS/RIOT/blob/d9be2491441c51f7945dbfd0d7fb77e7cbc60bea/drivers/include/led.h#L45-L55">https://github.com/RIOT-OS/RIOT/blob/d9be2491441c51f7945dbfd0d7fb77e7cbc60bea/drivers/include/led.h#L45-L55</a></p>
<p>(Sure, defining them to be e.g. <code>(void)0</code> would still be better, as this would still require a semicolon after the cpp macro. But this will also just work on boards with one or zero LEDs.)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10755#discussion_r248227124">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YG_Hvr4QqQe8Ix9KLVWOBxwJG41eks5vDv7PgaJpZM4Z7tCD">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YBg5xYhwAlZZfn21FDJHgivq-3LLks5vDv7PgaJpZM4Z7tCD.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@maribu commented on #10755"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10755#discussion_r248227124"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10755#discussion_r248227124",
"url": "https://github.com/RIOT-OS/RIOT/pull/10755#discussion_r248227124",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>