<p><b>@smlng</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10823#discussion_r250085490">sys/net/application_layer/nanocoap/nanocoap.c</a>:</p>
<pre style='color:#555'>> @@ -499,7 +499,35 @@ static size_t _encode_uint(uint32_t *val)
     return size;
 }
 
-static unsigned _put_delta_optlen(uint8_t *buf, unsigned offset, unsigned shift, unsigned val)
+/*
+ * Writes CoAP Option header. Expected to be called twice to write an option:
</pre>
<p>ah well, looking through the rest of the code its never used or done that way, and its an internal function, so its seems not that important.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10823#discussion_r250085490">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YCYjab3tXgd9ngKNFwAMClyUEm34ks5vGBYIgaJpZM4aIXZk">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YLEkPu4HB4q3VMXAcVr8zTlnLEXtks5vGBYIgaJpZM4aIXZk.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@smlng commented on #10823"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10823#discussion_r250085490"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10823#discussion_r250085490",
"url": "https://github.com/RIOT-OS/RIOT/pull/10823#discussion_r250085490",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>