<p><b>@cgundogan</b> commented on this pull request.</p>

<p>The code is sensible, I have a minor nit below. It is not that important to address it within this PR, though, since you did not modify that function but rather moved. I cannot test right now with an 6lbr.</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10817#discussion_r251067766">sys/net/gnrc/netif/gnrc_netif_device_type.c</a>:</p>
<pre style='color:#555'>> @@ -54,6 +54,81 @@ netopt_t gnrc_netif_get_l2addr_opt(const gnrc_netif_t *netif)
     return res;
 }
 
+#if defined(MODULE_CC110X) || defined(MODULE_NRFMIN)
+static void _create_eui64_from_short(const uint8_t *addr, size_t addr_len,
+                                     eui64_t *eui64)
+{
+    const unsigned offset = sizeof(eui64_t) - addr_len;
+
+    memset(eui64->uint8, 0, sizeof(eui64->uint8));
</pre>
<p>why did you not use an assignment statement here?</p>
<div class="highlight highlight-source-c"><pre>eui64->uint8[<span class="pl-c1">0</span>] = <span class="pl-c1">0x00</span>;</pre></div>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10817#discussion_r251069063">sys/net/gnrc/netif/gnrc_netif_device_type.c</a>:</p>
<pre style='color:#555'>> @@ -54,6 +54,81 @@ netopt_t gnrc_netif_get_l2addr_opt(const gnrc_netif_t *netif)
     return res;
 }
 
+#if defined(MODULE_CC110X) || defined(MODULE_NRFMIN)
+static void _create_eui64_from_short(const uint8_t *addr, size_t addr_len,
+                                     eui64_t *eui64)
+{
+    const unsigned offset = sizeof(eui64_t) - addr_len;
+
+    memset(eui64->uint8, 0, sizeof(eui64->uint8));
</pre>
<p>okay, further down I did see that you basically moved this function up without any modifications.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10817#pullrequestreview-196614914">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YKGBe3PkR_aRe27jFdRiiOwxxfuEks5vG0J1gaJpZM4aID8z">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YHJ0726q54Iu-88N7L3g2Csa86wrks5vG0J1gaJpZM4aID8z.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cgundogan commented on #10817"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10817#pullrequestreview-196614914"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10817#pullrequestreview-196614914",
"url": "https://github.com/RIOT-OS/RIOT/pull/10817#pullrequestreview-196614914",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>