<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1437538" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/lebrush">@lebrush</a> I'm really sorry for what happened here. I was not really confident in reviewing this one at the time you opened it, and this stalled for no good reason.</p>
<p>We encountered one of the issues which are solved here and a colleague opened <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="403297427" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/10872" data-hovercard-type="pull_request" data-hovercard-url="/RIOT-OS/RIOT/pull/10872/hovercard" href="https://github.com/RIOT-OS/RIOT/pull/10872">#10872</a>. I've run a couple of tests and when trying to reproduced I encountered another issue which is also fixed by your PR.</p>
<p>Would you mind rebasing this then we could merge? If you don't have time, could someone else take this over?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/6441#issuecomment-458073489">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YFgaOWxpMnopyMXzMn4GTiQCnnmPks5vHs-agaJpZM4LpU_q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YGPlhHijAF7n71WjaHbEpsswoKSyks5vHs-agaJpZM4LpU_q.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@vincent-d in #6441: @lebrush I'm really sorry for what happened here. I was not really confident in reviewing this one at the time you opened it, and this stalled for no good reason.\r\n\r\nWe encountered one of the issues which are solved here and a colleague opened #10872. I've run a couple of tests and when trying to reproduced I encountered another issue which is also fixed by your PR.\r\n\r\nWould you mind rebasing this then we could merge? If you don't have time, could someone else take this over?"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/6441#issuecomment-458073489"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/6441#issuecomment-458073489",
"url": "https://github.com/RIOT-OS/RIOT/pull/6441#issuecomment-458073489",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>