<p><b>@cgundogan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/9523#discussion_r252940674">sys/shell/commands/sc_gnrc_icmpv6_echo.c</a>:</p>
<pre style='color:#555'>> +
+        msg_receive(&msg);
+        switch (msg.type) {
+            case GNRC_NETAPI_MSG_TYPE_RCV: {
+                _handle_reply(&data, msg.content.ptr);
+                gnrc_pktbuf_release(msg.content.ptr);
+                break;
+            }
+            case _SEND_NEXT_PING:
+                _pinger(&data);
+                break;
+            case _PING_FINISH:
+                goto finish;
+            default:
+                /* requeue wrong packets */
+                msg_send(&msg, sched_active_pid);
</pre>
<p>What other messages can appear here? Shouldn't they be dropped instead of requeued? I can't see another <code>msg_recv</code> anywhere here that handles other types of messages, so the queue would get full with garbage ..</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/9523#pullrequestreview-198935368">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YLfMjOyk8FAREJLPygMz9bN6eZSUks5vI9nUgaJpZM4VH4rL">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YJklbsivY98u97yRxErq5p4OQqXSks5vI9nUgaJpZM4VH4rL.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cgundogan commented on #9523"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/9523#pullrequestreview-198935368"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/9523#pullrequestreview-198935368",
"url": "https://github.com/RIOT-OS/RIOT/pull/9523#pullrequestreview-198935368",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>