<p><b>@keestux</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10750#discussion_r253591824">drivers/sht2x/sht2x.c</a>:</p>
<pre style='color:#555'>> +    }
+
+    i2c_acquire(BUS);
+    res = i2c_read_regs(BUS, ADDR,
+                        second_mem_addr, data2, sizeof(data2), I2C_REG16);
+    i2c_release(BUS);
+    if (res < 0) {
+        return -1;
+    }
+    DEBUG("[SHT2x] ident (2): %02x %02x %02x\n", data2[0], data2[1], data2[2]);
+    DEBUG("[SHT2x] ident (2): %02x %02x %02x\n", data2[3], data2[4], data2[5]);
+    for (size_t ix = 0; ix < sizeof(data2); ix += 3) {
+        if (sht2x_checkcrc(&data2[ix], 2, data2[ix + 2]) != 0) {
+            DEBUG("[SHT2x] checksum error, second (ix=%d)\n", ix);
+        }
+    }
</pre>
<p>Hmm, I want to add a return SHT2X_ERR_CRC. In that case the loop is still needed.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10750#discussion_r253591824">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YMtz-303jeItGgKspdgxMNjwWf9rks5vKH6IgaJpZM4Z6NZZ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YGAC2nTEkc8jEcGUQIOspmXZHHGhks5vKH6IgaJpZM4Z6NZZ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@keestux commented on #10750"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10750#discussion_r253591824"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10750#discussion_r253591824",
"url": "https://github.com/RIOT-OS/RIOT/pull/10750#discussion_r253591824",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>