<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=19396439" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/MrKevinWeiss">@MrKevinWeiss</a> We see the message on both boards, it is displayed before on <code>nucleo-f103rb</code>. And yes it is expected as all messages sent are saved to the <code>logfile</code>.</p>
<p>A test for this is important, but I would not put it in <code>examples/hello-world</code>.<br>
Here it is not really testing <code>hello-world</code> just using one of its property to test something else.</p>
<p>I found about it while testing the <code>riotnode</code> wrapping <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406806748" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/10949" data-hovercard-type="pull_request" data-hovercard-url="/RIOT-OS/RIOT/pull/10949/hovercard" href="https://github.com/RIOT-OS/RIOT/pull/10949">#10949</a><br>
(Currently is only a rewrite as a class on the pexpect initialization).<br>
And have a dedicated library only test using a fake node over there:</p>
<p><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/cladmi/RIOT/commit/f386f3997beb19d1074b082e70116f0f4c8abac7/hovercard" href="https://github.com/cladmi/RIOT/commit/f386f3997beb19d1074b082e70116f0f4c8abac7">cladmi@<tt>f386f39</tt></a></p>
<p>Would that be enough or do you prefer to also have a board test for this too ?</p>
<p>One issue I see for tests with a real board is that it may require multiple firmwares for testing everything. But it could make sense to have a few directories in <code>test/</code> to handle these integration tests too.</p>
<p>With all this, should I add dedicated test to this PR instead of the throwaway commit ?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10952#issuecomment-462297018">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YD4lBHlaPPh0lkrjS4Sqc3MGDKYaks5vMVUYgaJpZM4ajadZ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YCFOVjg8kmHkk_y5FrbgnEYBTkgCks5vMVUYgaJpZM4ajadZ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cladmi in #10952: @MrKevinWeiss We see the message on both boards, it is displayed before on `nucleo-f103rb`. And yes it is expected as all messages sent are saved to the `logfile`.\r\n\r\nA test for this is important, but I would not put it in `examples/hello-world`.\r\nHere it is not really testing `hello-world` just using one of its property to test something else.\r\n\r\nI found about it while testing the `riotnode` wrapping https://github.com/RIOT-OS/RIOT/pull/10949\r\n(Currently is only a rewrite as a class on the pexpect initialization).\r\nAnd have a dedicated library only test using a fake node over there:\r\n\r\nhttps://github.com/cladmi/RIOT/commit/f386f3997beb19d1074b082e70116f0f4c8abac7\r\n\r\nWould that be enough or do you prefer to also have a board test for this too ?\r\n\r\nOne issue I see for tests with a real board is that it may require multiple firmwares for testing everything. But it could make sense to have a few directories in `test/` to handle these integration tests too.\r\n\r\nWith all this, should I add dedicated test to this PR instead of the throwaway commit ?"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10952#issuecomment-462297018"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10952#issuecomment-462297018",
"url": "https://github.com/RIOT-OS/RIOT/pull/10952#issuecomment-462297018",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>