<p><b>@miri64</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10999#discussion_r256069871">tests/rng/test.c</a>:</p>
<pre style='color:#555'>> @@ -154,7 +154,7 @@ void test_distributions(uint32_t samples)
 
         /* count bits */
         for (int i = 0; i < 32; i++) {
-            if (value & (1 << i)) {
+            if (value & (1u << i)) {
</pre>
<p>Shouldn't it be <code>1LU</code> to fit 32-bit?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10999#pullrequestreview-202812827">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YNzT7uTtN4Iw0XUWlsogGsOLuB3hks5vMv3SgaJpZM4a2WUV">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YFWd7CEN2yIvMFzPIqrbfdVm7W-Kks5vMv3SgaJpZM4a2WUV.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miri64 commented on #10999"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10999#pullrequestreview-202812827"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10999#pullrequestreview-202812827",
"url": "https://github.com/RIOT-OS/RIOT/pull/10999#pullrequestreview-202812827",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>