<p><b>@miri64</b> approved this pull request.</p>

<p>Code-wise the change looks good to me. I also compiled the <code>tests/bench_*</code> tests for <code>z1</code> (MSP-430) and got the following size differences (<code>bin-master</code> is  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/RIOT-OS/RIOT/commit/f8a7c026f2a83a29323bfcef19b88f8cd28a0d47/hovercard" href="https://github.com/RIOT-OS/RIOT/commit/f8a7c026f2a83a29323bfcef19b88f8cd28a0d47"><tt>f8a7c02</tt></a>, the current merge-base of this PR with master, and <code>bin</code> is <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/RIOT-OS/RIOT/commit/3eb7953b1a0f04581ebccbe38d65dac4e02e509f/hovercard" href="https://github.com/RIOT-OS/RIOT/commit/3eb7953b1a0f04581ebccbe38d65dac4e02e509f"><tt>3eb7953</tt></a>, the current <code>HEAD</code> of this PR when I did this). In both cases I used <code>RIOT_VERSION_OVERRIDE=""</code>.</p>
<pre><code>text     data    bss     dec     BOARD/BINDIRBASE
-14     0       0       -14     z1
7294    16      1582    8892    master-bin
7280    16      1582    8878    bin

tests_bench_mutex_pingpong
text    data    bss     dec     BOARD/BINDIRBASE
-10     0       0       -10     z1
6648    16      1584    8248    master-bin
6638    16      1584    8238    bin

tests_bench_runtime_coreapis
text    data    bss     dec     BOARD/BINDIRBASE
8       0       0       8       z1
7946    16      1080    9042    master-bin
7954    16      1080    9050    bin

tests_bench_sched_nop
text    data    bss     dec     BOARD/BINDIRBASE
-6      0       0       -6      z1
6326    16      1068    7410    master-bin
6320    16      1068    7404    bin

tests_bench_sizeof_coretypes
text    data    bss     dec     BOARD/BINDIRBASE
-6      0       0       -6      z1
5622    16      1046    6684    master-bin
5616    16      1046    6678    bin

tests_bench_thread_flags_pingpong
text    data    bss     dec     BOARD/BINDIRBASE
6       0       0       6       z1
6540    16      1580    8136    master-bin
6546    16      1580    8142    bin

tests_bench_thread_yield_pingpong
text    data    bss     dec     BOARD/BINDIRBASE
-6      0       0       -6      z1
6378    16      1580    7974    master-bin
6372    16      1580    7968    bin

tests_bench_timers
text    data    bss     dec     BOARD/BINDIRBASE
-10     0       0       -10     z1
15770   130     3248    19148   master-bin
15760   130     3248    19138   bin
</code></pre>
<p>Here are the test results (first <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/RIOT-OS/RIOT/commit/f8a7c026f2a83a29323bfcef19b88f8cd28a0d47/hovercard" href="https://github.com/RIOT-OS/RIOT/commit/f8a7c026f2a83a29323bfcef19b88f8cd28a0d47"><tt>f8a7c02</tt></a> then <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/RIOT-OS/RIOT/commit/3eb7953b1a0f04581ebccbe38d65dac4e02e509f/hovercard" href="https://github.com/RIOT-OS/RIOT/commit/3eb7953b1a0f04581ebccbe38d65dac4e02e509f"><tt>3eb7953</tt></a>):</p>
<ul>
<li><code>tests/bench_msg_pingpong</code>: increase in performance (9562 / 9596)</li>
<li><code>tests/bench_mutex_pingpong</code>: increase in performance (10131 / 10196)</li>
<li><code>tests/bench_runtime_coreapis</code>: no performance change</li>
<li><code>tests/bench_sched_nop</code>: increase in performance (36667 / 36836)</li>
<li><code>tests/bench_sizeof_coretypes</code> size of <code>tcp->status</code> increases from 1 to 2. Due to alignment padding the size of <code>thread_t</code> raises by 2 from 26 to 28.</li>
<li><code>tests/bench_thread_flags_pingpong</code>: decrease in performance (9930 / 9893)</li>
<li><code>tests/bench_thread_yield_pingpong</code>: increase in performance (16653 / 16723)</li>
<li><code>tests/bench_timers</code>: I get an error in both cases <code>Error -1 intializing reference timer</code> (so unrelated + I believe that test has nothing to do with the others ;-))</li>
</ul>
<p>(remark: <code>make test</code> failed for <code>bench_runtime_coreapis</code> here <a href="https://github.com/RIOT-OS/RIOT/blob/f8a7c026f2a83a29323bfcef19b88f8cd28a0d47/tests/bench_runtime_coreapis/tests/01-run.py#L24">https://github.com/RIOT-OS/RIOT/blob/f8a7c026f2a83a29323bfcef19b88f8cd28a0d47/tests/bench_runtime_coreapis/tests/01-run.py#L24</a> in both <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/RIOT-OS/RIOT/commit/f8a7c026f2a83a29323bfcef19b88f8cd28a0d47/hovercard" href="https://github.com/RIOT-OS/RIOT/commit/f8a7c026f2a83a29323bfcef19b88f8cd28a0d47"><tt>f8a7c02</tt></a> and <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/RIOT-OS/RIOT/commit/3eb7953b1a0f04581ebccbe38d65dac4e02e509f/hovercard" href="https://github.com/RIOT-OS/RIOT/commit/3eb7953b1a0f04581ebccbe38d65dac4e02e509f"><tt>3eb7953</tt></a>. I guess the timeout of the expect is just a bit too tight for the MSP-430)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10989#pullrequestreview-203189230">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YPRQVNGIzE1A0-M2FnsfgoImVQoLks5vNAjFgaJpZM4a0ZOI">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YDGuyJvwJrcK1U7h1U-JraOSEqizks5vNAjFgaJpZM4a0ZOI.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miri64 approved #10989"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10989#pullrequestreview-203189230"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10989#pullrequestreview-203189230",
"url": "https://github.com/RIOT-OS/RIOT/pull/10989#pullrequestreview-203189230",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>