<p><b>@gschorcht</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/9917#discussion_r257619865">cpu/esp8266/include/common.h</a>:</p>
<pre style='color:#555'>> @@ -83,6 +83,12 @@ extern "C" {
 #define CHECK_PARAM(cond)         if (!(cond)) return;
 #endif
 
+
+#define LOG_TAG_ERROR(tag, fmt, ...)   LOG_ERROR("[%s] " fmt, tag, ##__VA_ARGS__)
</pre>
<p>Not used in <code>cpu/esp8266</code> but in <code>cpu/esp_common/esp_now</code> netdev, e.g., here <a href="https://github.com/RIOT-OS/RIOT/blob/ac775b8ae5e3f5a385239a16ebbdcb505b1cae89/cpu/esp_common/esp-now/esp_now_netdev.c#L351">https://github.com/RIOT-OS/RIOT/blob/ac775b8ae5e3f5a385239a16ebbdcb505b1cae89/cpu/esp_common/esp-now/esp_now_netdev.c#L351</a></p>
<p>That is, when <code>esp_now</code> is used, they are required. These macros will be moved later to <code>cpu/esp_common</code> in further cleanup PRs. But for the moment and this PR, they are required in <code>cpu/esp8266</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/9917#discussion_r257619865">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YFUEGmjl9roUUAe2f2B_EVA_bY2Aks5vOnWwgaJpZM4Wi5xp">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YPROd5CvIdA7SMoKjUSOGbdyfAsOks5vOnWwgaJpZM4Wi5xp.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gschorcht commented on #9917"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/9917#discussion_r257619865"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/9917#discussion_r257619865",
"url": "https://github.com/RIOT-OS/RIOT/pull/9917#discussion_r257619865",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>