<p><b>@PeterKietzmann</b> commented on this pull request.</p>

<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5381296" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/leandrolanzieri">@leandrolanzieri</a> I left a few comments, please address them. Furthermore, what is your opinion about the pseudo-module preparation in this PR?</p>
<p>Other than that I ran the test on a nucleo-f103rb and got the expected 1Hz output</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/9838#discussion_r257646328">drivers/ds323x/ds3234.c</a>:</p>
<pre style='color:#555'>> + *
+ * @file
+ * @brief       Driver for the DS3234 Extremely Accurate SPI Bus RTC with
+ *              Integrated Crystal and SRAM, from Maxim
+ *
+ * @author      Joakim NohlgĂ„rd <joakim.nohlgard@eistec.se>
+ * @}
+ */
+
+#include <stdint.h>
+#include <errno.h>
+#include "ds3234.h"
+#include "ds323x_regs.h"
+#include "fmt.h"
+
+#define ENABLE_DEBUG    (1)
</pre>
<p>Please disable by default</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/9838#discussion_r257652397">drivers/ds323x/ds3234.c</a>:</p>
<pre style='color:#555'>> +}
+
+int ds3234_pps_init(const ds3234_params_t *dev)
+{
+    /* initialize CS pin */
+    int res = spi_init_cs(dev->spi, dev->cs);
+    if (res < 0) {
+        return DS3234_NO_SPI;
+    }
+    DEBUG("ds3234: init on SPI_DEV(%u)\n", dev->spi);
+
+    if (ENABLE_DEBUG) {
+        for (int k = 0; k <= 0x19; ++k) {
+            uint8_t dbg_reg = 0;
+            ds3234_read_reg(dev, k, 1, &dbg_reg);
+            print_byte_hex(k);
</pre>
<p>This has a dependency to the <code>fmt</code> module.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/9838#discussion_r257670563">drivers/ds323x/include/ds3234_params.h</a>:</p>
<pre style='color:#555'>> +#include "board.h"
+#include "ds3234.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @name    Set default configuration parameters for the DS3234 devices
+ * @{
+ */
+#ifndef DS3234_PARAM_SPI
+#define DS3234_PARAM_SPI                (SPI_DEV(0))
+#endif
+#ifndef DS3234_PARAM_CS
+#define DS3234_PARAM_CS                 (SPI_HWCS(0))
</pre>
<p>I think <code>GPIO_PIN(0, 0)</code> would be the more common way here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/9838#pullrequestreview-204727060">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YK1bt9_5K7zg_l6glSXrxtnp6sqLks5vOpsQgaJpZM4WLTZQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YNsY7-k-PQri0LanwUDswhgzqu3Bks5vOpsQgaJpZM4WLTZQ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@PeterKietzmann commented on #9838"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/9838#pullrequestreview-204727060"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/9838#pullrequestreview-204727060",
"url": "https://github.com/RIOT-OS/RIOT/pull/9838#pullrequestreview-204727060",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>