<blockquote>
<p>Because it is adding dynamic code for static configuration (that moreover is not supposed to be changed).</p>
</blockquote>
<p>I know what you mean, but we are talking about DEBUG statements, right? In that case, just imagine someone changing NDP_HOP_LIMIT just to still see "255" in the debug output. The WTF factor will be much higher than the couple of extra cycles needed to convert the number to a string. So I'd say not using the define is premature optimization.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11011#issuecomment-465058426">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YMMFoq-fSU5GOxfOCLCJ6XYSl3Q9ks5vO8X5gaJpZM4a6-1t">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YFuRCaGkw9v5_N5XlrLjvmxD5OOtks5vO8X5gaJpZM4a6-1t.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kaspar030 in #11011: \u003e Because it is adding dynamic code for static configuration (that moreover is not supposed to be changed).\r\n\r\nI know what you mean, but we are talking about DEBUG statements, right? In that case, just imagine someone changing NDP_HOP_LIMIT just to still see \"255\" in the debug output. The WTF factor will be much higher than the couple of extra cycles needed to convert the number to a string. So I'd say not using the define is premature optimization."}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11011#issuecomment-465058426"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11011#issuecomment-465058426",
"url": "https://github.com/RIOT-OS/RIOT/pull/11011#issuecomment-465058426",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>