<p><b>@jcarrano</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11003#discussion_r257988235">tests/shell/Makefile</a>:</p>
<pre style='color:#555'>> @@ -1,4 +1,5 @@
 DEVELHELP=0
+
</pre>
<p>Oops, that slipped through when I splitted the change.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11003#discussion_r257989721">makefiles/tools/serial.inc.mk</a>:</p>
<pre style='color:#555'>> @@ -19,4 +19,7 @@ ifeq ($(RIOT_TERMINAL),pyterm)
 else ifeq ($(RIOT_TERMINAL),picocom)
     export TERMPROG  ?= picocom
     export TERMFLAGS ?= --nolock --imap lfcrlf --echo --baud "$(BAUD)" "$(PORT)"
+else ifeq ($(RIOT_TERMINAL),miniterm.py)
+    export TERMPROG  ?= miniterm.py
+    export TERMFLAGS ?= --eol CRLF "$(PORT)" "$(BAUD)"
</pre>
<p>With local echo you end up having <em>double</em> echo, as the shell echoes too, and miniterm does not do line buffering, eg.:</p>
<pre><code>> hheellpp
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11003#discussion_r257988235">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YLflgbITAzwWJPAAJUlRd9VXBvtAks5vO9u5gaJpZM4a2i0A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YDGDmu9pHlM4L_u-h0ZXrtJY-JWnks5vO9u5gaJpZM4a2i0A.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jcarrano commented on #11003"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11003#discussion_r257988235"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11003#discussion_r257988235",
"url": "https://github.com/RIOT-OS/RIOT/pull/11003#discussion_r257988235",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>