<p>After one night on this, should the wrapper really take care of a <code>term</code> that cannot clean itself correctly¬†?</p>
<p>It requires adding <code>psutil</code> dependency (or play with <code>ps</code> output) and doing complex and not guaranteed solutions (if a new process is spawned after the first kill) to detect an issue where the terminal process would not correctly clean its children.</p>
<p>Which means, when a user uses <code>make term</code> and does not do a process group kill, it could leave remaining processes.</p>
<p>I would be maybe in favor of documenting correctly to which signals the <code>TERMPROG</code> should react to cleanup and fix them to work properly.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10949#issuecomment-465512086">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YGRnCefs8KhlE7Ztz8T5k_Hqxc-Vks5vPSAXgaJpZM4ajUc6">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YF3mmlxTgirAQyLHdu2G60a_n0Eeks5vPSAXgaJpZM4ajUc6.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cladmi in #10949: After one night on this, should the wrapper really take care of a `term` that cannot clean itself correctly¬†?\r\n\r\nIt requires adding `psutil` dependency (or play with `ps` output) and doing complex and not guaranteed solutions (if a new process is spawned after the first kill) to detect an issue where the terminal process would not correctly clean its children.\r\n\r\nWhich means, when a user uses `make term` and does not do a process group kill, it could leave remaining processes.\r\n\r\nI would be maybe in favor of documenting correctly to which signals the `TERMPROG` should react to cleanup and fix them to work properly."}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10949#issuecomment-465512086"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10949#issuecomment-465512086",
"url": "https://github.com/RIOT-OS/RIOT/pull/10949#issuecomment-465512086",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>