<p><b>@skullbox305</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10983#discussion_r259594165">drivers/ph_oem/ph_oem_saul.c</a>:</p>
<pre style='color:#555'>> +    /* Read raw pH value */
+    if (ph_oem_read_ph(mydev, res->val) < 0) {
+        return -ECANCELED;
+    }
+    res->unit = UNIT_PH;
+    res->scale = -3;
+
+    return 1;
+}
+
+/* Sets the temperature compensation for taking accurate pH readings */
+static int set_temp_compensation(const void *dev, phydat_t *res)
+{
+    const ph_oem_t *mydev = dev;
+
+    ph_oem_set_compensation(mydev, res->val[0]);
</pre>
<p>added check to detect errors</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10983#discussion_r259594165">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YK88-liEWAS1c3GC6YU9dob-YWB4ks5vQbVcgaJpZM4azXyV">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YLD29mW9v0CAjmmVvT6QwbJbvBiiks5vQbVcgaJpZM4azXyV.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@skullbox305 commented on #10983"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10983#discussion_r259594165"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10983#discussion_r259594165",
"url": "https://github.com/RIOT-OS/RIOT/pull/10983#discussion_r259594165",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>