<p><b>@smlng</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11003#discussion_r259769111">tests/shell/Makefile</a>:</p>
<pre style='color:#555'>> @@ -12,4 +12,10 @@ BOARD_BLACKLIST += chronos
 
 TEST_ON_CI_WHITELIST += all
 
+# In order to properly test and debug the shell it is better to use a terminal
+# program that does not modify the input and output streams and has no buffering.
+ifneq ($(BOARD), native)
+  RIOT_TERMINAL?=miniterm.py
</pre>
<p>please put spaces around <code>?=</code> look nicer and (more) inline with the rest of our makefiles stuff.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11003#pullrequestreview-207325760">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YJ0C5BNUZoGjKOVFz8hujop1BxW8ks5vQ79QgaJpZM4a2i0A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YFz09oUBvIRDmM2MTwh9UTtBnRP3ks5vQ79QgaJpZM4a2i0A.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@smlng commented on #11003"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11003#pullrequestreview-207325760"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11003#pullrequestreview-207325760",
"url": "https://github.com/RIOT-OS/RIOT/pull/11003#pullrequestreview-207325760",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>