<p><b>@kaspar030</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10315#discussion_r260655888">sys/include/suit.h</a>:</p>
<pre style='color:#555'>> + *
+ * The parser is based on draft version 1 of the specification.
+ *
+ * @see https://tools.ietf.org/html/draft-moran-suit-manifest-01
+ *
+ * @{
+ *
+ * @brief       Decoding functions for a SUIT manifest
+ * @author      Koen Zandberg <koen@bergzand.net>
+ */
+
+#ifndef SUIT_H
+#define SUIT_H
+
+#ifdef __cplusplus
+extern "C" {
</pre>
<blockquote>
<p>is there a rule/guideline for the order of this somewhere?</p>
</blockquote>
<p>"do as we always did" combined with "close in reversed open order":</p>
<ul>
<li>copyright</li>
<li>doxygen open (with file info)</li>
<li>header guard open</li>
<li>includes</li>
<li>ifdef c++ open</li>
<li>code</li>
<li>ifdef c++ close</li>
<li>header guard close</li>
<li>doxygen close</li>
</ul>
<p>for the includes it is somewhat important to be before the "extern C" as they <em>might</em> have other namespacing.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10315#discussion_r260655888">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YCi7gEy4rUmPmbkRWOkBw2JgTo7Dks5vRk3MgaJpZM4YLVZU">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YBJe62oYNLZv7FiAhwx8Cr3bllYRks5vRk3MgaJpZM4YLVZU.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kaspar030 commented on #10315"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10315#discussion_r260655888"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10315#discussion_r260655888",
"url": "https://github.com/RIOT-OS/RIOT/pull/10315#discussion_r260655888",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>