<h3>Contribution description</h3>
<p>Prepare to keep working when <code>FLASHFILE</code> is used for the FLASHER.</p>
<h3>Limitation</h3>
<p>This does not declare the generated file to flash as <code>FLASHFILE</code> as it is currently not a file target.<br>
This would come after <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="385215418" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/10494" data-hovercard-type="pull_request" data-hovercard-url="/RIOT-OS/RIOT/pull/10494/hovercard" href="https://github.com/RIOT-OS/RIOT/pull/10494">#10494</a></p>
<h3>Testing procedure</h3>
<h4>Nothing broke</h4>
<p>The previous behavior did not change:</p>
<pre><code>make -C tests/mcuboot/ mcuboot-flash 
</code></pre>
<pre><code>make -C tests/mcuboot/ term
make: Entering directory '/home/harter/work/git/worktree/riot_release/tests/mcuboot'
/home/harter/work/git/worktree/riot_release/dist/tools/pyterm/pyterm -p "/dev/ttyACM0" -b "115200"
Twisted not available, please install it if you want to use pyterm's JSON capabilities
2019-03-05 18:06:21,953 - INFO # Connect to serial port /dev/ttyACM0
Welcome to pyterm!
Type '/exit' to exit.

2019-03-05 18:09:20,682 - INFO # Hello MCUBoot!
2019-03-05 18:09:20,686 - INFO # You are running RIOT on a(n) nrf52dk board.
2019-03-05 18:09:20,689 - INFO # This board features a(n) nrf52 MCU.
2019-03-05 18:09:20,692 - INFO # The startup address is: 0x8200
</code></pre>
<h4>Future should work</h4>
<p>FLASHFILE is indeed given to the flash target.<br>
It can be tested by replacing the flasher with echo $(FLASHFILE) and seeing the file being printed:</p>
<pre><code>RIOT_CI_BUILD=1  make --no-print-directory -C tests/mcuboot mcuboot-flash FLASHER=echo FFLAGS='FLASHFILE: $(FLASHFILE)'
Building application "tests_mcuboot" for "nrf52dk" with MCU "nrf52".

   text    data     bss     dec     hex filename
   8108     136    2604   10848    2a60 /home/harter/work/git/worktree/riot_release/tests/mcuboot/bin/nrf52dk/tests_mcuboot.elf

Re-linking for MCUBoot at 0x8000...


Signed with /home/harter/work/git/worktree/riot_release/tests/mcuboot/bin/nrf52dk/key.pem for version 1.1.1+1\


/home/harter/work/git/worktree/riot_release/dist/tools/dlcache/dlcache.sh: getting "http://download.riot-os.org/mynewt.mcuboot.bin" from cache
FLASH_ADDR=0x0 echo FLASHFILE: /home/harter/work/git/worktree/riot_release/tests/mcuboot/bin/nrf52dk/mcuboot.bin
FLASHFILE: /home/harter/work/git/worktree/riot_release/tests/mcuboot/bin/nrf52dk/mcuboot.bin
FLASH_ADDR=0x8000 echo FLASHFILE: /home/harter/work/git/worktree/riot_release/tests/mcuboot/bin/nrf52dk/signed-tests_mcuboot.bin
FLASHFILE: /home/harter/work/git/worktree/riot_release/tests/mcuboot/bin/nrf52dk/signed-tests_mcuboot.bin
</code></pre>
<h3>Issues/PRs references</h3>
<p>This is part of <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="308966540" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/8838" data-hovercard-type="pull_request" data-hovercard-url="/RIOT-OS/RIOT/pull/8838/hovercard" href="https://github.com/RIOT-OS/RIOT/pull/8838">#8838</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/RIOT-OS/RIOT/pull/11112'>https://github.com/RIOT-OS/RIOT/pull/11112</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>makefiles/mcuboot: prepare for when FLASHFILE is used</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11112/files#diff-0">makefiles/mcuboot.mk</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/11112.patch'>https://github.com/RIOT-OS/RIOT/pull/11112.patch</a></li>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/11112.diff'>https://github.com/RIOT-OS/RIOT/pull/11112.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11112">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YG7qnTTOeYz1HZIMs2VQeXptydRmks5vTqUYgaJpZM4bfF17">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YLJGjtlyH2WUCJVpjAsSOICW1y_eks5vTqUYgaJpZM4bfF17.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"makefiles/mcuboot: prepare for when FLASHFILE is used (#11112)"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11112"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11112",
"url": "https://github.com/RIOT-OS/RIOT/pull/11112",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>