<p><b>@maribu</b> requested changes on this pull request.</p>

<p>To me the RSSI info would be a nice addition to the ping info :-)<br>
Please have a look at the inline comments.</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11092#discussion_r262839130">sys/shell/commands/sc_gnrc_icmpv6_echo.c</a>:</p>
<pre style='color:#555'>> @@ -362,6 +363,9 @@ static void _print_reply(_ping_data_t *data, gnrc_pktsnip_t *icmpv6,
         }
         printf("%u bytes from %s: icmp_seq=%u ttl=%u", (unsigned)icmpv6->size,
                from_str, recv_seq, hoplimit);
+        if (netif_hdr && netif_hdr->rssi) {
+            printf(" rssi=%d dBm", netif_hdr->rssi);
</pre>
<p><a href="api.riot-os.org/structgnrc__netif__hdr__t.html"><code>gnrc_netif_hdr_t::rssi</code></a> is of type <code>int16_t</code>, so the format string should be <code>" rssi=%" PRId16 " dBm"</code>.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11092#discussion_r262840715">sys/shell/commands/sc_gnrc_icmpv6_echo.c</a>:</p>
<pre style='color:#555'>> @@ -322,7 +322,8 @@ static void _pinger(_ping_data_t *data)
 }
 
 static void _print_reply(_ping_data_t *data, gnrc_pktsnip_t *icmpv6,
-                         ipv6_addr_t *from, unsigned hoplimit)
+                         ipv6_addr_t *from, unsigned hoplimit,
+                         gnrc_netif_hdr_t* netif_hdr)
</pre>
<p>I think it might be a more consistent API to expect <code>int16_t rssi</code> directly here, not the full netif header. But I'm not insisting on this.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11092#pullrequestreview-211101248">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YHKHNEG1a3OHdU1Ccx14MlR-nKAvks5vT4EWgaJpZM4bcC3O">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YITq-n5Y4FywBe9czeCQ06hWoGiwks5vT4EWgaJpZM4bcC3O.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@maribu requested changes on #11092"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11092#pullrequestreview-211101248"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11092#pullrequestreview-211101248",
"url": "https://github.com/RIOT-OS/RIOT/pull/11092#pullrequestreview-211101248",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>