<p><b>@maribu</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263371047">cpu/atmega_common/periph/gpio.c</a>:</p>
<pre style='color:#555'>> @@ -59,6 +63,88 @@
 #endif
 
 static gpio_isr_ctx_t config[GPIO_EXT_INT_NUMOF];
+
+/**
+ * @brief detects ammount of possible PCINTs
+ */
+#if defined(MODULE_ATMEGA_PCINT) || defined(MODULE_ATMEGA_PCINT0) || defined(MODULE_ATMEGA_PCINT1) || defined(MODULE_ATMEGA_PCINT2) || defined(MODULE_ATMEGA_PCINT3)
+#include "atmega_pcint.h"
+
+#ifndef ATMEGA_PCINT_MAP_PCINT0
+#error Please define pin change interrupts in atmega_pcint.h
+#endif /* ATMEGA_PCINT_MAP_PCINT0 */
+
+/**
+ * @brief check which pcints should be enabled!
+ */
+#if defined(MODULE_ATMEGA_PCINT) || defined(MODULE_ATMEGA_PCINT0)
</pre>
<p>OK, I'm convinced. But maybe it would improve debugging when instead of</p>
<div class="highlight highlight-source-c"><pre>#<span class="pl-k">if</span> defined(MODULE_ATMEGA_PCINT1) && defined(ATMEGA_PCINT_MAP_PCINT1)
...
#<span class="pl-k">endif</span></pre></div>
<p>this is used:</p>
<div class="highlight highlight-source-c"><pre>#<span class="pl-k">ifdef</span> MODULE_ATMEGA_PCINT1
#<span class="pl-k">ifndef</span> ATMEGA_PCINT_MAP_PCINT1
#<span class="pl-k">error</span> "Either mapping for pin change interrupt bank 1 is missing or not supported by the MCU"
#<span class="pl-k">endif</span> <span class="pl-c"><span class="pl-c">/*</span> ATMEGA_PCINT_MAP_PCINT1 <span class="pl-c">*/</span></span>
...

#<span class="pl-k">endif</span> <span class="pl-c"><span class="pl-c">/*</span> MODULE_ATMEGA_PCINT1 <span class="pl-c">*/</span></span>
...
#endif</pre></div>
<p>(This would indeed require cpu-depend handling of <code>atmega_pcint</code>, but uses will now what went wrong when the manually added <code>atmega_pcint<NUM></code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263371047">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YCo_uDG4tJ3Z58Lrl4lcdDCwCRdyks5vUQ1PgaJpZM4biyPa">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YA3TSvFO-0gVeBYZr1Wcm7hTGFcGks5vUQ1PgaJpZM4biyPa.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@maribu commented on #11122"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263371047"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263371047",
"url": "https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263371047",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>