<p><b>@maribu</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11124#discussion_r263539334">sys/net/gnrc/network_layer/sixlowpan/gnrc_sixlowpan.c</a>:</p>
<pre style='color:#555'>> @@ -222,8 +217,7 @@ static void _receive(gnrc_pktsnip_t *pkt)
     }
 #endif
     else {
-        DEBUG("6lo: dispatch %02" PRIx8 " ... is not supported\n",
-              dispatch[0]);
+        DEBUG("6lo: dispatch %02x... is not supported\n", dispatch[0]);
</pre>
<p>I'm aware that in practice <code>float</code> gets promoted to <code>double</code> and all integer types smaller than <code>int</code> get promoted to <code>int</code>. But are you sure that is C standard? (At least ┬┤clang -Weverything<code>does not complain, so it might very well be.) If not, an</code>uint8_t<code>will be pushed on the argument stack and an</code>unsigned int<code>will be popped by</code>printf`.</p>
<p>I personally would do the cast even if this is officially specified, as it just looks strange if format specifier and argument are of different type</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11124#discussion_r263539334">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YHjjA_9o7VJEY_l5QcHRpidXigpVks5vUWyWgaJpZM4bjA18">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YOXL2VRc3vVSXHqyOxgnUTtLgpzKks5vUWyWgaJpZM4bjA18.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@maribu commented on #11124"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11124#discussion_r263539334"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11124#discussion_r263539334",
"url": "https://github.com/RIOT-OS/RIOT/pull/11124#discussion_r263539334",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>