<p><b>@maribu</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263439268">cpu/atmega1284p/Makefile.dep</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,5 @@
+ifneq (,$(filter atmega_pcint,$(USEMODULE)))
+    USEMODULE += atmega_pcint0 atmega_pcint1 atmega_pcint2
</pre>
<p>I also guess that all AVR MCUs have at least PCINT0 to PCINT2, so maybe move the code above to  <code>cpu/atmega_common/Makefile.include</code> and just add</p>
<pre><code>ifneq (,$(filter atmega_pcint,$(USEMODULE)))
    USEMODULE += atmega_pcint3
endif
</code></pre>
<p>to <code>cpu/atmega1284p/Makefile.include</code> to have only the special case handled at CPU level</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263439268">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YLdC2sGJ2bkkWt_TO1QFyeNI7HAIks5vUTMJgaJpZM4biyPa">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YLmgU_ZeVVpYb_wAxL3mUQIOMjWCks5vUTMJgaJpZM4biyPa.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@maribu commented on #11122"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263439268"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263439268",
"url": "https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263439268",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>