<p><b>@smlng</b> requested changes on this pull request.</p>

<p>looks good to me, some minor stuff</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11143#discussion_r264011358">sys/include/net/lorawan/hdr.h</a>:</p>
<pre style='color:#555'>> +/**
+ * @brief Get LoRaWAN header frame pending bit
+ *
+ * @param[in] hdr LoRaWAN header
+ *
+ * @return value of the frame pending bit
+ */
+static inline bool lorawan_hdr_get_frame_pending(lorawan_hdr_t *hdr)
+{
+    return (hdr->fctrl & 0x10);
+}
+
+/**
+ * @brief Set LoRaWAN header FOpts length
+ *
+ * @param hdr LoRaWAN header
</pre>
<p>missing <code>[in]</code> here, next and below</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11143#discussion_r264011384">sys/include/net/lorawan/hdr.h</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,266 @@
+/*
+ * Copyright (C) 2016 Fundación Inria Chile
</pre>
<p>this seems a bit outdated?</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11143#discussion_r264011397">sys/include/net/lorawan/hdr.h</a>:</p>
<pre style='color:#555'>> + *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @defgroup    net_lorawan_hdr    LoRaWAN header
+ * @ingroup     net_lorawan
+ * @brief       LoRaWAN header types and helper functions
+ * @{
+ *
+ * @file
+ * @brief   LoRaWAN header type and helper function definitions
+ *
+ * @author  José Ignacio Alamos <jose.alamos@inria.cl>
</pre>
<p>does the mail still work <g-emoji class="g-emoji" alias="smile" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f604.png">😄</g-emoji></p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11143#discussion_r264011439">sys/include/net/lorawan/hdr.h</a>:</p>
<pre style='color:#555'>> +
+#include <stdio.h>
+#include <stdint.h>
+#include <stdbool.h>
+
+#include "byteorder.h"
+#include "net/loramac.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @brief   Data type to represent a LoRaWAN packet header
+ *
+ * @details This definition includes MHDR and FHDR in the same structure.
</pre>
<p>I don't think that <code>@details</code> is needed (here and below). At least it is hardly used in the RIOT docu else where</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11143#pullrequestreview-212573994">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YJWxzG9qagbV2XqM9bzESiMXStHtks5vVAtfgaJpZM4blqie">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YCFaiX_GhNj-mAi3shqp4sl-HM5Cks5vVAtfgaJpZM4blqie.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@smlng requested changes on #11143"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11143#pullrequestreview-212573994"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11143#pullrequestreview-212573994",
"url": "https://github.com/RIOT-OS/RIOT/pull/11143#pullrequestreview-212573994",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>