<p><b>@kb2ma</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11098#discussion_r264782060">sys/net/application_layer/nanocoap/nanocoap.c</a>:</p>
<pre style='color:#555'>> @@ -323,7 +323,15 @@ ssize_t coap_handle_req(coap_pkt_t *pkt, uint8_t *resp_buf, unsigned resp_buf_le
             continue;
         }
 
-        int res = strcmp((char *)uri, resource->path);
+        int res;
</pre>
<p>I'd like to be sure there is no misunderstanding. Why did you inline the implementation in the header file?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11098#discussion_r264782060">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YAIgVu9xL5gIG1LrVrFB2xmyYQFlks5vV9ymgaJpZM4bcjwW">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YF-4qMpHRX8YhHwtLZ3eTeIhKBBRks5vV9ymgaJpZM4bcjwW.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kb2ma commented on #11098"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11098#discussion_r264782060"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11098#discussion_r264782060",
"url": "https://github.com/RIOT-OS/RIOT/pull/11098#discussion_r264782060",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>