<h3>Contribution description</h3>
<p>Update to use FLASHFILE as file to be flashed on the board.</p>
<p>This also now removes the compatibility hack in <code>riotboot</code>.</p>
<h3>Testing procedure</h3>
<p>We need to test that boards using edbg would still work with this.</p>
<h4>Boards using edbg:</h4>
<pre><code>echo ${EDBG_BOARDS} 
arduino-zero samd21-xpro saml10-xpro saml11-xpro saml21-xpro samr21-xpro samr30-xpro
</code></pre>
<h4>Test flashing normal examples with the board</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> samr21-xpro <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=241401" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cladmi">@cladmi</a></li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> ...</li>
</ul>
<h4>Test without board</h4>
<p>I replaced FLASHER by 'true' to only show the FFLAGS and get the same output with master and this pull request:</p>
<pre><code>for board in ${EDBG_BOARDS} ; do echo ${board}; BOARD=${board} make -C examples/hello-world/ --no-print-directory FLASHER=true flash-only; done
arduino-zero
true  -t atmel_cm0p -b -v -p -f /home/harter/work/git/RIOT/examples/hello-world/bin/arduino-zero/hello-world.bin
samd21-xpro
true  -t atmel_cm0p -b -v -p -f /home/harter/work/git/RIOT/examples/hello-world/bin/samd21-xpro/hello-world.bin
saml10-xpro
true  -t mchp_cm23 -b -v -p -f /home/harter/work/git/RIOT/examples/hello-world/bin/saml10-xpro/hello-world.bin
saml11-xpro
true  -t mchp_cm23 -b -v -p -f /home/harter/work/git/RIOT/examples/hello-world/bin/saml11-xpro/hello-world.bin
saml21-xpro
true  -t atmel_cm0p -b -v -p -f /home/harter/work/git/RIOT/examples/hello-world/bin/saml21-xpro/hello-world.bin
samr21-xpro
true  -t atmel_cm0p -b -v -p -f /home/harter/work/git/RIOT/examples/hello-world/bin/samr21-xpro/hello-world.bin
samr30-xpro
true  -t atmel_cm0p -b -v -p -f /home/harter/work/git/RIOT/examples/hello-world/bin/samr30-xpro/hello-world.bin
</code></pre>
<h4><code>riotboot</code> test</h4>
<p>Test running <code>tests/riotboot</code> test for <code>samr21-xpro</code> and <code>saml21-xpro</code></p>
<pre><code>BOARD=samr21-xpro make -C tests/riotboot flash test

2019-03-13 15:27:51,462 - INFO # main(): This is RIOT! (Version: 2019.04-devel-475-g4af35)
2019-03-13 15:27:51,463 - INFO # Hello riotboot!
2019-03-13 15:27:51,482 - INFO # You are running RIOTmain(): This is RIOT! (Version: 2019.04-devel-475-g4af35)
2019-03-13 15:27:51,483 - INFO # Hello riotboot!
2019-03-13 15:27:51,487 - INFO # You are running RIOT on a(n) samr21-xpro board.
2019-03-13 15:27:51,491 - INFO # This board features a(n) samd21 MCU.
2019-03-13 15:27:51,494 - INFO # riotboot_test: running from slot 0
2019-03-13 15:27:51,497 - INFO # Image magic_number: 0x544f4952
2019-03-13 15:27:51,499 - INFO # Image Version: 0x00000000
2019-03-13 15:27:51,502 - INFO # Image start address: 0x00001100
2019-03-13 15:27:51,504 - INFO # Header chksum: 0x7f7aaea1
2019-03-13 15:27:51,505 - INFO # 
> curslotnr
2019-03-13 15:27:51,527 - INFO #  curslotnr
2019-03-13 15:27:51,529 - INFO # Current slot=0
> curslothdr
curslothdr
2019-03-13 15:27:51,582 - INFO #  curslothdr
2019-03-13 15:27:51,585 - INFO # Image magic_number: 0x544f4952
2019-03-13 15:27:51,587 - INFO # Image Version: 0x00000000
2019-03-13 15:27:51,590 - INFO # Image start address: 0x00001100
2019-03-13 15:27:51,592 - INFO # Header chksum: 0x7f7aaea1
2019-03-13 15:27:51,592 - INFO # 
> getslotaddr 0
getslotaddr 0
2019-03-13 15:27:51,645 - INFO #  getslotaddr 0
2019-03-13 15:27:51,647 - INFO # Slot 0 address=0x00001100
> dumpaddrs
dumpaddrs
2019-03-13 15:27:51,699 - INFO #  dumpaddrs
2019-03-13 15:27:51,703 - INFO # slot 0: metadata: 0x1000 image: 0x00001100
2019-03-13 15:27:51,707 - INFO # slot 1: metadata: 0x20800 image: 0x00000000

</code></pre>
<h3>Issues/PRs references</h3>
<p>Split out of <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="308966540" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/8838" data-hovercard-type="pull_request" data-hovercard-url="/RIOT-OS/RIOT/pull/8838/hovercard" href="https://github.com/RIOT-OS/RIOT/pull/8838">#8838</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/RIOT-OS/RIOT/pull/11172'>https://github.com/RIOT-OS/RIOT/pull/11172</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>riotboot: remove compatibility for HEXFILE as file to flash</li>
  <li>makefiles/edbg.inc.mk: use FLASHFILE</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11172/files#diff-0">makefiles/boot/riotboot.mk</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11172/files#diff-1">makefiles/tools/edbg.inc.mk</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11172/files#diff-2">tests/riotboot/Makefile</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/11172.patch'>https://github.com/RIOT-OS/RIOT/pull/11172.patch</a></li>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/11172.diff'>https://github.com/RIOT-OS/RIOT/pull/11172.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11172">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YDdN9yRRITTk6gen6qCtbjWTC8Hgks5vWQxngaJpZM4btYV0">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YFisvE9lXe_ccdpzItIiffiQuKrYks5vWQxngaJpZM4btYV0.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"makefiles/edbg.inc.mk: use FLASHFILE (#11172)"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11172"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11172",
"url": "https://github.com/RIOT-OS/RIOT/pull/11172",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>