<p><b>@haukepetersen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11103#discussion_r265913182">boards/nrf52832-mdk/include/gpio_params.h</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,60 @@
+/*
</pre>
<p>just some idea for future improvement: how about we generalize <code>boards/common/nrf52xxxdk/include/gpio_params.h</code> a bit more, so we can re-use it in this and other boards? We simply would have to make the <code>name</code> (and possibly the <code>flags</code>) field 'definable' and there would be no need to duplicate this file anymore.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11103#pullrequestreview-214946015">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YFJx2qr6PHwQUlx3nPQ7byC02ahZks5vW23KgaJpZM4beSHm">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YMn7iW1r7CyJaMqhs8SrYyY3jX2Qks5vW23KgaJpZM4beSHm.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@haukepetersen commented on #11103"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11103#pullrequestreview-214946015"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11103#pullrequestreview-214946015",
"url": "https://github.com/RIOT-OS/RIOT/pull/11103#pullrequestreview-214946015",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>