<p><b>@aabadie</b> requested changes on this pull request.</p>

<p>Codewise looks good in general, just minor stuff. Unfortunately I don't have the board for testing. Any chance that you could lend me one ? ;)</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11250#discussion_r268515472">boards/samr34-xpro/Makefile.dep</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,7 @@
+ifneq (,$(filter semtech-loramac,$(USEMODULE)))
</pre>
<p>Like for the b-l072z-lrwan1, I would replace this block with the following:</p>
⬇️ Suggested change
<pre style="color: #555">-ifneq (,$(filter semtech-loramac,$(USEMODULE)))
+ifneq (,$(filter netdev_default,$(USEMODULE)))
+  USEMODULE += sx1276
+endif
</pre>

<p>You may also want to add the board to the variable <code>BOARD_PROVIDES_NETIF</code> in <code>examples/default</code></p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11250#discussion_r268516014">boards/samr34-xpro/board.c</a>:</p>
<pre style='color:#555'>> +void led_init(void);
+
+void board_init(void)
+{
+    /* initialize the CPU */
+    cpu_init();
+
+    /* initialize the boards LEDs */
+    led_init();
+
+    /* initialize board specific pins for LoRa */
+#ifdef MODULE_SX127X
+    gpio_init(TXCO_PWR_PIN, GPIO_OUT);
+    gpio_set(TXCO_PWR_PIN);
+    gpio_init(TX_OUTPUT_SEL_PIN, GPIO_OUT);
+    gpio_write(TX_OUTPUT_SEL_PIN, !sx127x_params[0].paselect);
</pre>
<p>Why not directly use <code>SX127X_PARAM_PASELECT</code> define instead of <code>sx127x_params[0].paselect</code>? That would be cleaner.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11250#discussion_r268516263">boards/samr34-xpro/include/board.h</a>:</p>
<pre style='color:#555'>> +#endif
+
+/**
+ * @name Semtech SX1276 configuration
+ * @{
+ */
+#define SX127X_PARAM_SPI                    (SPI_DEV(0))
+#define SX127X_PARAM_SPI_NSS                GPIO_PIN(1, 31)       /* D10 */
+#define SX127X_PARAM_RESET                  GPIO_PIN(1, 15)       /* A0 */
+#define SX127X_PARAM_DIO0                   GPIO_PIN(1, 16)      /* D2 */
+#define SX127X_PARAM_DIO1                   GPIO_PIN(0, 11)       /* D3 */
+#define SX127X_PARAM_DIO2                   GPIO_PIN(0, 12)       /* D4 */
+#define SX127X_PARAM_DIO3                   GPIO_PIN(1, 17)       /* D5 */
+#define SX127X_PARAM_PASELECT               (SX127X_PA_RFO)
+
+#define SX127X_PARAMS                   {   .spi       = SX127X_PARAM_SPI,     \
</pre>
<p>You don't need to redefine this one since other defines below will be use in <code>sx127x_params.h</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11250#pullrequestreview-218177583">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YIiKGzlWKS5M-KpedB3AJwVg7smcks5vaH9BgaJpZM4cFJxS">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YClAQ4HlHJ0B0EVnoox_v8cFWfKZks5vaH9BgaJpZM4cFJxS.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@aabadie requested changes on #11250"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11250#pullrequestreview-218177583"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11250#pullrequestreview-218177583",
"url": "https://github.com/RIOT-OS/RIOT/pull/11250#pullrequestreview-218177583",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>