<p><b>@haukepetersen</b> requested changes on this pull request.</p>

<p>minor findings in doc, please clarify :-)</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10589#discussion_r269288827">sys/include/net/l2util.h</a>:</p>
<pre style='color:#555'>> + *
+ * @pre @p iid was based on a hardware address
+ * @pre The number of bytes available at @p addr is less or equal to
+ *      @ref L2UTIL_ADDR_MAX_LEN.
+ *
+ * @attention   When `NDEBUG` is not defined, the node fails with an assertion
+ *              instead of returning `-ENOTSUP`
+ *
+ * @param[in] dev_type  The network device type of the device the @p iid came
+ *                      from (either because it is based on the configured
+ *                      address of the device or from a packet that came over
+ *                      it).
+ * @param[in] iid       An IID based on @p dev_type.
+ * @param[out] addr     The hardware address. It is assumed that @p iid was
+ *                      based on a hardware address and that the available bytes
+ *                      in @p addr are less or equal to
</pre>
<p>greater or equal? Or <code>must be able to hold the expected link layer address length</code>?</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10589#discussion_r269290010">sys/include/net/l2util.h</a>:</p>
<pre style='color:#555'>> + *                      address of the device or from a packet that came over
+ *                      it).
+ * @param[in] iid       An IID based on @p dev_type.
+ * @param[out] addr     The hardware address. It is assumed that @p iid was
+ *                      based on a hardware address and that the available bytes
+ *                      in @p addr are less or equal to
+ *                      @ref L2UTIL_ADDR_MAX_LEN.
+ *
+ * @return  Length of resulting @p addr on success.
+ * @return  `-ENOTSUP`, when @p dev_type does not support reverse IID
+ *          conversion.
+ */
+int l2util_ipv6_iid_to_addr(int dev_type, const eui64_t *iid, uint8_t *addr);
+
+/**
+ * @brief   Derives the length link-layer address in an NDP link-layer address
</pre>
<p>Derives the length <strong>of</strong> the link layer address?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10589#pullrequestreview-219126792">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YLIeszqPZ3cdFb3ViiD7Jbzv5AgVks5van9agaJpZM4ZNiuc">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YOPylroYTWG0cJZax24ofypgYrWaks5van9agaJpZM4ZNiuc.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@haukepetersen requested changes on #10589"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/10589#pullrequestreview-219126792"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10589#pullrequestreview-219126792",
"url": "https://github.com/RIOT-OS/RIOT/pull/10589#pullrequestreview-219126792",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>