<h3>Contribution description</h3>
<p>This PR changes the approach of peripheral configurations for DAC channels in board definitions to the usual RIOT approach. With these changes, peripheral configurations use static const arrays in the <code>boards/esp32*/periph_conf.h</code> files and define the <code>*_NUMOF</code> macros using the size of these static array.</p>
<p>The static configuration arrays contain only definitions that can be changed by the board definition or the application. They do not contain any MCU implementation detail. The board definitions use preprocessor defines as before to fill these static configuration arrays. This makes it possible to override all configurations either with the make command or application specific configuration files.</p>
<p>Please note that commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/RIOT-OS/RIOT/commit/8b48dfd62b9ef74dcf3bf023d2fe30fefe76dee3/hovercard" href="https://github.com/RIOT-OS/RIOT/commit/8b48dfd62b9ef74dcf3bf023d2fe30fefe76dee3"><tt>8b48dfd</tt></a> is in also in related PRs to get each PR compilable separately.</p>
<h3>Testing procedure</h3>
<p>Compilation and test with the most common ESP32 board should be executed</p>
<pre><code>make BOARD=esp32-wroom-32 -C tests/periph_dac flash test
</code></pre>
<h3>Issues/PRs references</h3>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/RIOT-OS/RIOT/pull/11290'>https://github.com/RIOT-OS/RIOT/pull/11290</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>cpu/esp32: GPIO defs required for periph conf</li>
  <li>cpu/esp32: DAC config approach changed</li>
  <li>boards/esp32: DAC config approach changed</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11290/files#diff-0">boards/common/esp32/include/periph_conf_common.h</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11290/files#diff-1">boards/esp32-olimex-evb/Makefile.features</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11290/files#diff-2">cpu/esp32/include/periph_cpu.h</a>
    (114)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11290/files#diff-3">cpu/esp32/periph/adc.c</a>
    (13)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/11290.patch'>https://github.com/RIOT-OS/RIOT/pull/11290.patch</a></li>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/11290.diff'>https://github.com/RIOT-OS/RIOT/pull/11290.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11290">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YA-C7u9JRx6-HWlgkietxxJlqIgCks5vaynVgaJpZM4cNMd1">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YHx2L3xa4k89I_BbwM0wELlNqc8tks5vaynVgaJpZM4cNMd1.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"boards/esp32: changes the approach for configurations of DAC channels in board definitions (#11290)"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11290"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11290",
"url": "https://github.com/RIOT-OS/RIOT/pull/11290",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>