<p><b>@haukepetersen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11278#discussion_r269621077">pkg/nimble/scanlist/nimble_scanlist.c</a>:</p>
<pre style='color:#555'>> +    if (ble_addr_cmp(&e->addr, addr) == 0) {
+        return 1;
+    }
+    return 0;
+}
+
+static nimble_scanlist_entry_t *_find(const ble_addr_t *addr)
+{
+    return (nimble_scanlist_entry_t *)clist_foreach(&_list, _finder,
+                                                    (void *)addr);
+}
+
+void nimble_scanlist_init(void)
+{
+    for (unsigned i = 0; i < (sizeof(_mem) / sizeof(_mem[0])); i++) {
+        clist_rpush(&_pool, &_mem[i].node);
</pre>
<p>True, that would be a possibility in general. But in this particular case this is not an issue, as items are only taken from the pool, and the only operation to put them back is by calling clear(), so not really a high chance of loosing an item anywhere.</p>
<p>Hope you can live with this for now. At some point, we might as well look into how we can add unittest to these submodules in a nice way - lets see if this submodules survives until then :-)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11278#discussion_r269621077">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YLvPN9LId5cW0Oz5tG5Uzav9VqmLks5va40TgaJpZM4cLKoO">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YNZ-UrD6IxHvPmMMXvAqhWBD90srks5va40TgaJpZM4cLKoO.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@haukepetersen commented on #11278"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11278#discussion_r269621077"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11278#discussion_r269621077",
"url": "https://github.com/RIOT-OS/RIOT/pull/11278#discussion_r269621077",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>