<p><b>@miri64</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11300#discussion_r269893209">sys/include/net/tcp.h</a>:</p>
<pre style='color:#555'>>  } tcp_hdr_opt_t;
 
+/**
+ * @brief   Get the start of the TCP option value
+ *
+ * @param[in]   opt   TCP option field helper structure contiguous memory
+ *
+ * @returns     pointer to first byte of the value
+ */
+inline static uint8_t *tcp_hdr_opt_value_ptr(tcp_hdr_opt_t *opt){
</pre>
<p>Making inline functions non-static will cause the linker to fail once you include <code>net/tcp.h</code> in multiple c-files ;-).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11300#discussion_r269893209">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YHXUvGH_qVyUb7XkgFcVsoTj6VYCks5vbHqogaJpZM4cOzmZ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YHMjZMmSoD7N5TqsHsDIeu-yd2sCks5vbHqogaJpZM4cOzmZ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miri64 commented on #11300"}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11300#discussion_r269893209"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11300#discussion_r269893209",
"url": "https://github.com/RIOT-OS/RIOT/pull/11300#discussion_r269893209",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>