<p>I agree with the usage (and changes) of <code>fmt</code> the other changes I find a bit controversial. Mainly that adding a new sensor now requires to change 2 <code>enums</code> instead of one, however I like the general idea of having a class and start numbering from there.</p>
<p>TL;DR: please split this in 2 PRs one for <code>fmt</code> (which I would merge directly) and one for the other change which (to me) need some discussion, for instance <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5381296" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/leandrolanzieri">@leandrolanzieri</a> might have an opinion on this too.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11392#issuecomment-483189502">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AEn7YP6FDIn91VQQejWgSCosD26R7XcFks5vhE5RgaJpZM4cvlMU">mute the thread</a>.<img src="https://github.com/notifications/beacon/AEn7YI1qkfLP97FGSDBuprA68333-DHDks5vhE5RgaJpZM4cvlMU.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/RIOT-OS/RIOT","title":"RIOT-OS/RIOT","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/RIOT-OS/RIOT"}},"updates":{"snippets":[{"icon":"PERSON","message":"@smlng in #11392: I agree with the usage (and changes) of `fmt` the other changes I find a bit controversial. Mainly that adding a new sensor now requires to change 2 `enums` instead of one, however I like the general idea of having a class and start numbering from there.\r\n\r\nTL;DR: please split this in 2 PRs one for `fmt` (which I would merge directly) and one for the other change which (to me) need some discussion, for instance @leandrolanzieri might have an opinion on this too."}],"action":{"name":"View Pull Request","url":"https://github.com/RIOT-OS/RIOT/pull/11392#issuecomment-483189502"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11392#issuecomment-483189502",
"url": "https://github.com/RIOT-OS/RIOT/pull/11392#issuecomment-483189502",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>