<p><b>@dylad</b> commented on this pull request.</p>

<p>Great PR ! This is something I wanted to do for a long time. Thanks, I'll give it a try this week.</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11486#discussion_r281087994">cpu/saml21/Makefile.include</a>:</p>
<pre style='color:#555'>> @@ -3,5 +3,17 @@ export CPU_FAM  = saml21
 
 USEMODULE += pm_layered
 
+ifneq (,$(filter saml21j18b saml21j18a,$(CPU_MODEL)))
</pre>
<p>Can you also add SAMR30 here please ? We might find a better way for this later to avoid adding new MCU.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11486#discussion_r281088096">cpu/saml21/ldscripts/saml21.ld</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,35 @@
+/*
+ * Copyright (C) 2019 ML!PA Consulting GmbH
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @addtogroup      cpu_saml21
+ * @{
+ *
+ * @file
+ * @brief           Memory definitions for Atmel SAML21
</pre>
⬇️ Suggested change
<pre style="color: #555">- * @brief           Memory definitions for Atmel SAML21
+ * @brief           Memory definitions for Microchip SAML21
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11486#pullrequestreview-233859068">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYBEHIWLXZJCI2EOHN3PT7PKDANCNFSM4HKVC6WQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYBM7AMWCYUU7FXSJCLPT7PKDA5CNFSM4HKVC6W2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBXYGP7A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11486#pullrequestreview-233859068",
"url": "https://github.com/RIOT-OS/RIOT/pull/11486#pullrequestreview-233859068",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>