<p><b>@kaspar030</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11310#discussion_r282406192">sys/stdio_uart/stdio_uart.c</a>:</p>
<pre style='color:#555'>>  
 void stdio_init(void)
 {
+    uart_rx_cb_t cb;
+    void *arg;
+
+#ifdef MODULE_STDIO_UART_RX
+    cb = (uart_rx_cb_t) isrpipe_write_one;
+    arg = &stdio_uart_isrpipe;
+#else
+#ifdef USE_ETHOS_FOR_STDIO
</pre>
<p>hm, ethos itself doesn't need <em>stdio</em>_uart_rx.<br>
stdio-over-ethos should probably be a pseudomodule...</p>
<p>I guess as is this is fine for now.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11310#discussion_r282406192">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYGTWRD5A6R6ZGT3HYLPUPUXDANCNFSM4HCJNBJQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYEKCQZYE6L3RMYAHELPUPUXDA5CNFSM4HCJNBJ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBYETULA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11310#discussion_r282406192",
"url": "https://github.com/RIOT-OS/RIOT/pull/11310#discussion_r282406192",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>