<h3>Contribution description</h3>
<p>During the testing of a device driver for the u-blox SAM-M8Q GPS receiver on the NRF52840-MDK board I noticed that I couldn't get the slave to ACK over I2C no matter what I tried (seemed like a short on SDA between master and slave). The driver works just fine on the Zolertia Firefly.<br>
The nRF52840 datasheet states on page 431 to set the GPIO drive configuration (bit 8-10) of the PIN_CNF register to S0D1(0x06) for both, SCL and SDA. I fixed this in the cpu/nrf5x_common as well as cpu/nrf52. The nrf51 already sets the drive configuration to S0D1.</p>
<h3>Testing procedure</h3>
<p>Test on any board with a NRF52 with I2C configured. For me it works fine now with the NRF52840-MDK board and the u-blox SAM-M8Q as well as the Bosch BMX280 devices.</p>
<h3>Issues/PRs references</h3>
<p>None</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/RIOT-OS/RIOT/pull/11512'>https://github.com/RIOT-OS/RIOT/pull/11512</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>cpu/nrf52: i2c bugfix</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11512/files#diff-0">cpu/nrf52/periph/i2c.c</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11512/files#diff-1">cpu/nrf5x_common/include/periph_cpu_common.h</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/11512/files#diff-2">cpu/nrf5x_common/periph/gpio.c</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/11512.patch'>https://github.com/RIOT-OS/RIOT/pull/11512.patch</a></li>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/11512.diff'>https://github.com/RIOT-OS/RIOT/pull/11512.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11512">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFWG4C3MOHJAWKOBITPVE3ENANCNFSM4HMOFSBA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYDTEMT2JQ3FKTMLOUTPVE3ENA5CNFSM4HMOFSBKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GTMKSWA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11512",
"url": "https://github.com/RIOT-OS/RIOT/pull/11512",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>