<p><b>@benpicco</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11410#discussion_r286066577">drivers/mrf24j40/mrf24j40_internal.c</a>:</p>
<pre style='color:#555'>> +#else
+    (void) dev;
+#endif
+}
+
+void mrf24j40_disable_pa_lna(mrf24j40_t *dev)
+{
+#if MRF24J40_USE_EXT_PA_LNA
+    /* Disable automatic switch on PA/LNA */
+    mrf24j40_reg_write_long(dev, MRF24J40_REG_TESTMODE, MRF24J40_TESTMODE_RSSIWAIT0);
+
+    /* Configure all GPIOs as Output */
+    mrf24j40_reg_write_short(dev, MRF24J40_REG_TRISGPIO, 0xF);
+
+    /* Disable all GPIO outputs */
+    mrf24j40_reg_write_short(dev, MRF24J40_REG_GPIO, 0);
</pre>
<p><code>enable_pa_lna()</code> will enable the voltage regulator for the PA and automatic PA/LNA control by the chip.<br>
<code>enable_lna()</code> will disable the voltage regulator for the PA as well as automatic PA/LNA control, then manually enable the LNA.</p>
<p>Maybe I should call it <code>enable_auto_pa_lna()</code> to make that clearer.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11410?email_source=notifications&email_token=ABE7WYHRWW6GZ5SF5QZNNDDPWQDVTA5CNFSM4HGUCFMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZHZ5DQ#discussion_r286066577">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYA6VJ3VETDVDLXB3IDPWQDVTANCNFSM4HGUCFMA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYCSTBNENRZGWSW2T2DPWQDVTA5CNFSM4HGUCFMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZHZ5DQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11410?email_source=notifications\u0026email_token=ABE7WYHRWW6GZ5SF5QZNNDDPWQDVTA5CNFSM4HGUCFMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZHZ5DQ#discussion_r286066577",
"url": "https://github.com/RIOT-OS/RIOT/pull/11410?email_source=notifications\u0026email_token=ABE7WYHRWW6GZ5SF5QZNNDDPWQDVTA5CNFSM4HGUCFMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZHZ5DQ#discussion_r286066577",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>