<p>I think splitting the linker script related things in a separate PR that makes <code>tests/cortexm_common_ldscript</code> pass is good. It shows the dependencies for adding <code>riotboot</code>.</p>
<p>I would keep the <code>OUTPUT_FORMAT/OUTPUT_ARCH</code> modifications out of this PR/the split for the moment as it is a different type of review to do than the offsets and should trigger other reviewers.</p>
<p>It would leave defining the features and the <code>RIOTBOOT_LEN</code> in this PR at the end.</p>
<p>I will update the PR description to show the intermediate steps.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11562?email_source=notifications&email_token=ABE7WYHG6GULMCAGDISAFSDPYYXCVA5CNFSM4HORROP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW36KUI#issuecomment-498591057">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYAIKYHA5YCMLI2MJCLPYYXCVANCNFSM4HORROPQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYCSMZBJMSMG7N6O3ITPYYXCVA5CNFSM4HORROP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW36KUI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11562?email_source=notifications\u0026email_token=ABE7WYHG6GULMCAGDISAFSDPYYXCVA5CNFSM4HORROP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW36KUI#issuecomment-498591057",
"url": "https://github.com/RIOT-OS/RIOT/pull/11562?email_source=notifications\u0026email_token=ABE7WYHG6GULMCAGDISAFSDPYYXCVA5CNFSM4HORROP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW36KUI#issuecomment-498591057",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>