<p><b>@kaspar030</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11598#discussion_r291079828">Makefile.dep</a>:</p>
<pre style='color:#555'>> @@ -398,6 +398,10 @@ ifneq (,$(filter stdio_rtt,$(USEMODULE)))
 endif
 
 ifneq (,$(filter shell,$(USEMODULE)))
+  USEMODULE += stdio_rx
</pre>
<p>could we maybe rename this module to "stdio_stdin" or just "stdin"? rx only makes sense for uart.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11598?email_source=notifications&email_token=ABE7WYB4OR447YFJPAO5A4LPZDFN7A5CNFSM4HQFEOT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2YFCBY#pullrequestreview-246436103">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYANFJ63DNZWAASYOE3PZDFN7ANCNFSM4HQFEOTQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYFVJZ4OFDH7DBVGDFTPZDFN7A5CNFSM4HQFEOT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2YFCBY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11598?email_source=notifications\u0026email_token=ABE7WYB4OR447YFJPAO5A4LPZDFN7A5CNFSM4HQFEOT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2YFCBY#pullrequestreview-246436103",
"url": "https://github.com/RIOT-OS/RIOT/pull/11598?email_source=notifications\u0026email_token=ABE7WYB4OR447YFJPAO5A4LPZDFN7A5CNFSM4HQFEOT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2YFCBY#pullrequestreview-246436103",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>