<p><b>@miri64</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11666#discussion_r292145261">sys/include/net/eui48.h</a>:</p>
<pre style='color:#555'>> @@ -56,6 +56,24 @@ static inline void eui48_to_eui64(eui64_t *eui64, const eui48_t *addr)
     eui64->uint8[7] = addr->uint8[5];
 }
 
+/**
+ * @name EUI-48 bit flags contained in the first octet
+ *
+ * @see IEEE 802-2001 section 9.2
+ * @{
+ */
+
+/**
+ * @brief Locally administered address.
+ */
+#define EUI48_LOCAL_ADMIN_FLAG  0x02
</pre>
<p>I know that this is about the uniqueness of the address, not the scope ;-). I just think the functions to set/clear a flag and the flag should have matching names. Either we call the function to set it then <code>_set_local_admin()</code> as well or we change the name here. I think <code>local</code> is completely sufficient, as it is well documented above that <code>local</code> means "locally administered" and for those unaware of the distinction it won't matter that much anyways.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11666?email_source=notifications&email_token=ABE7WYCQ74PGV64RNRS7EFDPZ2P6JA5CNFSM4HWRFD32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3COS4Q#discussion_r292145261">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFBRHPGI26DN7H2BRLPZ2P6JANCNFSM4HWRFD3Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYG5T2ZC4OM7FYHKYBLPZ2P6JA5CNFSM4HWRFD32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3COS4Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11666?email_source=notifications\u0026email_token=ABE7WYCQ74PGV64RNRS7EFDPZ2P6JA5CNFSM4HWRFD32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3COS4Q#discussion_r292145261",
"url": "https://github.com/RIOT-OS/RIOT/pull/11666?email_source=notifications\u0026email_token=ABE7WYCQ74PGV64RNRS7EFDPZ2P6JA5CNFSM4HWRFD32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3COS4Q#discussion_r292145261",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>