<p><b>@kYc0o</b> commented on this pull request.</p>

<p>Have minor comments, I'll test on my application and give feedback.</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10340#discussion_r292949920">drivers/cc110x/cc110x_rx_tx.c</a>:</p>
<pre style='color:#555'>> +
+#include "xtimer.h"
+#include "cc110x.h"
+#include "cc110x_internal.h"
+
+#define ENABLE_DEBUG    (0)
+#include "debug.h"
+
+/* Use NETDEV_EVENT_ISR to indicate that no event needs to be passed to upper
+ * layer at end of ISR, as ISR will never need this event
+ */
+#define NETDEV_NO_EVENT NETDEV_EVENT_ISR
+
+void cc110x_rx(cc110x_t *dev)
+{
+    //DEBUG("[cc110x] Going to RX\n");
</pre>
<p>Please uncomment this line.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10340#discussion_r292951192">drivers/cc110x/cc110x_rx_tx.c</a>:</p>
<pre style='color:#555'>> + */
+static netdev_event_t cc110x_rx_done(cc110x_t *dev)
+{
+    uint8_t lqi_crc;
+    int8_t rssi;
+
+    cc110x_read(dev, CC110X_REG_LQI, &lqi_crc);
+    cc110x_read(dev, CC110X_REG_RSSI, (uint8_t *)&rssi);
+
+    /* CRC_OK bit is most significant bit, see page 92 in the data sheet */
+    if (!(lqi_crc & 0x80)) {
+        DEBUG("[cc110x] ISR: CRC error, dropping frame\n");
+        /* Drop frame and go back to RX */
+        cc110x_rx(dev);
+        return NETDEV_EVENT_CRC_ERROR;
+    }
</pre>
<p>Should you first check if CRC check is enabled? In some cases the embedded CRC function is not needed and thus disabled. This check would drop the frame even if a valid (different) CRC can be calculated afterwards.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10340?email_source=notifications&email_token=ABE7WYGYTCXUEXEKASQDT5DP2EFABA5CNFSM4GCDBED2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3KHTOY#pullrequestreview-248805819">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYF7PBRNFCFDQCKU2ITP2EFABANCNFSM4GCDBEDQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYA4DWBEG5XASYOQ6LDP2EFABA5CNFSM4GCDBED2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3KHTOY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10340?email_source=notifications\u0026email_token=ABE7WYGYTCXUEXEKASQDT5DP2EFABA5CNFSM4GCDBED2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3KHTOY#pullrequestreview-248805819",
"url": "https://github.com/RIOT-OS/RIOT/pull/10340?email_source=notifications\u0026email_token=ABE7WYGYTCXUEXEKASQDT5DP2EFABA5CNFSM4GCDBED2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3KHTOY#pullrequestreview-248805819",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>