<p><b>@cladmi</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11670#discussion_r293724186">dist/tools/buildsystem_sanity_check/check.sh</a>:</p>
<pre style='color:#555'>> +# Deprecated variables or patterns
+# Prevent deprecated variables or patterns to re-appear after cleanup
+check_deprecated_vars_patterns() {
+    local patterns=()
+    local pathspec=()
+
+    patterns+=(-e 'FEATURES_MCU_GROUP')
+
+    # Pathspec with exclude should start by an inclusive pathspec in git 2.7.4
+    pathspec+=('*')
+
+    # Ignore this file when matching as it self matches
+    pathspec+=(":!${SCRIPT_PATH}")
+
+    git -C "${RIOTBASE}" grep "${patterns[@]}" -- "${pathspec[@]}" \
+        | sed '1i \\nDeprecated variables or patterns:'
</pre>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1375137" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/aabadie">@aabadie</a> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="454606403" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/11672" data-hovercard-type="pull_request" data-hovercard-url="/RIOT-OS/RIOT/pull/11672/hovercard" href="https://github.com/RIOT-OS/RIOT/pull/11672">#11672</a> was merged and changed the way to do the "buildsystem_sanity_check". Can you please rebase and adapt ?</p>
⬇️ Suggested change
<pre style="color: #555">-        | sed '1i \\nDeprecated variables or patterns:'
+        | error_with_message 'Deprecated variables or patterns:'
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11670#discussion_r293724286">dist/tools/buildsystem_sanity_check/check.sh</a>:</p>
<pre style='color:#555'>>  
 main() {
     local errors=''
 
     errors+="$(check_not_parsing_features)"
     errors+="$(check_not_exporting_variables)"
+    errors+="$(check_deprecated_vars_patterns)"
</pre>
<p>The function should now be added the list in <code>all_checks</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11670?email_source=notifications&email_token=ABE7WYE7TZYB4QI6DMUUFL3P2NOETA5CNFSM4HW3BTCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3RYNQA#pullrequestreview-249792192">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFV7QA32WIRGN52NBLP2NOETANCNFSM4HW3BTCA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYDPPCKNJLLRT4CPR3TP2NOETA5CNFSM4HW3BTCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3RYNQA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11670?email_source=notifications\u0026email_token=ABE7WYE7TZYB4QI6DMUUFL3P2NOETA5CNFSM4HW3BTCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3RYNQA#pullrequestreview-249792192",
"url": "https://github.com/RIOT-OS/RIOT/pull/11670?email_source=notifications\u0026email_token=ABE7WYE7TZYB4QI6DMUUFL3P2NOETA5CNFSM4HW3BTCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3RYNQA#pullrequestreview-249792192",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>