<p><b>@haukepetersen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11739#discussion_r298097336">sys/include/net/ble.h</a>:</p>
<pre style='color:#555'>> +#define BLE_GATT_SVC_BAS                    (0x180f)    /**< battery service */
+#define BLE_GATT_SVC_IPSS                   (0x1820)    /**< IP protocol support */
+/* add more on demand */
+/** @} */
+
+/**
+ * @name    Selected GATT characteristic UUIDs (16-bit)
+ *
+ * @see https://www.bluetooth.com/specifications/gatt/characteristics/
+ * @{
+ */
+#define BLE_GATT_CHAR_BATTERY_LEVEL         (0x2a19)    /**< battery level */
+#define BLE_GATT_CHAR_SYSTEM_ID             (0x2a23)    /**< system ID */
+#define BLE_GATT_CHAR_MODEL_NUMBER_STR      (0x2a24)    /**< model number */
+#define BLE_GATT_CHAR_SERIAL_NUMBER_STR     (0x2a25)    /**< serial number */
+#define BLE_GATT_CHAR_FW_REV_STR            (0x2A26)    /**< firmware revision */
</pre>
<p>yes, copy-paste typo, will fix.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11739?email_source=notifications&email_token=ABE7WYGB5LKINW4CYMWDSSTP4SE7BA5CNFSM4H3FUNBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB42NVIQ#discussion_r298097336">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYBLP2U4CLTGN4DSCGDP4SE7BANCNFSM4H3FUNBA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYAJTJSBE4AAOQE2V3LP4SE7BA5CNFSM4H3FUNBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB42NVIQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11739?email_source=notifications\u0026email_token=ABE7WYGB5LKINW4CYMWDSSTP4SE7BA5CNFSM4H3FUNBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB42NVIQ#discussion_r298097336",
"url": "https://github.com/RIOT-OS/RIOT/pull/11739?email_source=notifications\u0026email_token=ABE7WYGB5LKINW4CYMWDSSTP4SE7BA5CNFSM4H3FUNBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB42NVIQ#discussion_r298097336",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>