<p><b>@kb2ma</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11189#discussion_r298785979">sys/clif/clif.c</a>:</p>
<pre style='color:#555'>> +        return 1;
+    }
+
+    if (maxlen < 1) {
+        return CLIF_NO_SPACE;
+    }
+
+    *buf = LF_LINK_SEPARATOR_C;
+    return 1;
+}
+
+ssize_t clif_add_param(clif_param_t *param, char *buf, size_t maxlen)
+{
+    assert(param && param->key);
+
+    param->key_len = strlen(param->key);
</pre>
<p>Should we ignore the incoming value of key_len and assume that the key is 0-terminated? clif_get_param() sets key_len.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11189?email_source=notifications&email_token=ABE7WYDPTCPLVH7LGWFJX5TP43JUBA5CNFSM4G6TDMSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5BJKZA#pullrequestreview-256021860">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFRTDRUHBVACQFAMG3P43JUBANCNFSM4G6TDMSA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYD6JKJKKIDATFKWXM3P43JUBA5CNFSM4G6TDMSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5BJKZA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11189?email_source=notifications\u0026email_token=ABE7WYDPTCPLVH7LGWFJX5TP43JUBA5CNFSM4G6TDMSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5BJKZA#pullrequestreview-256021860",
"url": "https://github.com/RIOT-OS/RIOT/pull/11189?email_source=notifications\u0026email_token=ABE7WYDPTCPLVH7LGWFJX5TP43JUBA5CNFSM4G6TDMSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5BJKZA#pullrequestreview-256021860",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>