<p><b>@smlng</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10635#discussion_r298734987">tests/shell/Makefile</a>:</p>
<pre style='color:#555'>> @@ -20,4 +20,7 @@ TEST_ON_CI_WHITELIST += all
 
 APP_SHELL_FMT ?= NONE
 
+# needed to correctly test ling lines
</pre>
<p>/ling/long/ ?</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10635#discussion_r298735277">tests/shell/main.c</a>:</p>
<pre style='color:#555'>>  static const shell_command_t shell_commands[] = {
+    { "bufsize", "Get the shell's buffer size", print_shell_bufsize },
</pre>
<p>maybe plain and simple: "Get shell buffer size"?</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10635#discussion_r298742554">sys/shell/shell.c</a>:</p>
<pre style='color:#555'>>  void shell_run(const shell_command_t *shell_commands, char *line_buf, int len)
 {
     print_prompt();
 
     while (1) {
         int res = readline(line_buf, len);
 
-        if (res == EOF) {
-            break;
-        }
-
-        if (!res) {
-            handle_input_line(shell_commands, line_buf);
+        switch (res) {
+            case EOF:
+                goto shell_run_exit;
</pre>
<p>there are (better) places where <code>goto</code> has its (controversial) benefits - here it looks rather cosmetic (to me) and I would go for a simple <code>return;</code> as <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=4679640" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kaspar030">@kaspar030</a> suggested.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10635#discussion_r298742692">sys/shell/shell.c</a>:</p>
<pre style='color:#555'>>  void shell_run(const shell_command_t *shell_commands, char *line_buf, int len)
 {
     print_prompt();
 
     while (1) {
         int res = readline(line_buf, len);
 
-        if (res == EOF) {
-            break;
-        }
-
-        if (!res) {
-            handle_input_line(shell_commands, line_buf);
+        switch (res) {
</pre>
<p>as there is no other use of <code>res</code> could be replace with <code>switch (readline(line_buf, len)) {</code></p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10635#discussion_r298742786">sys/shell/shell.c</a>:</p>
<pre style='color:#555'>>          }
 
         print_prompt();
     }
+
+shell_run_exit:
</pre>
<p>removing <code>goto</code> make these 2 lines obsolete</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10635#discussion_r298743124">tests/shell/tests/01-run.py</a>:</p>
<pre style='color:#555'>> @@ -50,7 +50,18 @@ def check_cmd(child, cmd, expected):
 
 def testfunc(child):
     # check startup message
-    child.expect('test_shell.')
+    child.expect('test_shell.\r')
+
+    child.sendline('bufsize')
+    child.expect('([0-9]+)')
+
+    bufsize = int(child.match[1])
+
+    # check a long line
+    child.sendline("_"*bufsize + "whatever")
</pre>
<p>maybe use <code>foobar</code> or <code>42</code> instead <g-emoji class="g-emoji" alias="nerd_face" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f913.png">🤓</g-emoji></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10635?email_source=notifications&email_token=ABE7WYAQXU5P6GX6SY5HKPTP4Z2SNA5CNFSM4GLDIIH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5AZPMY#pullrequestreview-255956915">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYHXS7334ZALMBICM5TP4Z2SNANCNFSM4GLDIIHQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYAMWP2GPYADJNTDJ5DP4Z2SNA5CNFSM4GLDIIH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5AZPMY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10635?email_source=notifications\u0026email_token=ABE7WYAQXU5P6GX6SY5HKPTP4Z2SNA5CNFSM4GLDIIH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5AZPMY#pullrequestreview-255956915",
"url": "https://github.com/RIOT-OS/RIOT/pull/10635?email_source=notifications\u0026email_token=ABE7WYAQXU5P6GX6SY5HKPTP4Z2SNA5CNFSM4GLDIIH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5AZPMY#pullrequestreview-255956915",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>