<p><b>@fjmolinas</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11818#discussion_r301997319">sys/suit/coap.c</a>:</p>
<pre style='color:#555'>> +            return;
+        }
+
+        printf("suit_v4_parse() success\n");
+        if (!(manifest.state & SUIT_MANIFEST_HAVE_IMAGE)) {
+            puts("manifest parsed, but no image fetched");
+            return;
+        }
+
+        res = suit_v4_policy_check(&manifest);
+        if (res) {
+            return;
+        }
+
+#endif
+        if (res == 0) {
</pre>
<p>While reviewing <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="464650088" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/11805" data-hovercard-type="pull_request" data-hovercard-url="/RIOT-OS/RIOT/pull/11805/hovercard" href="https://github.com/RIOT-OS/RIOT/pull/11805">#11805</a> I realized <code>res</code> is uninitialized if <code>MODULE_SUIT_V4</code> is not used.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11818?email_source=notifications&email_token=ABE7WYGEOGEGZRG2TSTZNJDP6W3VRA5CNFSM4H63VM7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB57WS4A#pullrequestreview-260008304">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYHKNHDLK5NJPOGT4ZDP6W3VRANCNFSM4H63VM7A">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYCEV45KBVT6EA6YV4LP6W3VRA5CNFSM4H63VM7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB57WS4A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11818?email_source=notifications\u0026email_token=ABE7WYGEOGEGZRG2TSTZNJDP6W3VRA5CNFSM4H63VM7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB57WS4A#pullrequestreview-260008304",
"url": "https://github.com/RIOT-OS/RIOT/pull/11818?email_source=notifications\u0026email_token=ABE7WYGEOGEGZRG2TSTZNJDP6W3VRA5CNFSM4H63VM7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB57WS4A#pullrequestreview-260008304",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>