<p><b>@fjmolinas</b> requested changes on this pull request.</p>

<p>I tested <code>start_network.sh</code> by running the test in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="465256043" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/11818" data-hovercard-type="pull_request" data-hovercard-url="/RIOT-OS/RIOT/pull/11818/hovercard" href="https://github.com/RIOT-OS/RIOT/pull/11818">#11818</a> using wireless nodes. The BR was an <code>iotlab-m3</code>.</p>
<p>I also tested <code>gnrc_networking</code> on a <code>samr21-xpro</code> with the same BR and I was able to ping the <code>samr21-xpro</code> from my local host.</p>
<p>If you agree with my changes than squash directly.</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11840#discussion_r304270769">dist/tools/ethos/start_network.sh</a>:</p>
<pre style='color:#555'>>  cleanup() {
-    echo "Cleaning up..."
-    remove_tap
-    ip a d fd00:dead:beef::1/128 dev lo
-    kill ${UHCPD_PID}
+    [ -n "${SETUP_NETWORK_PID}" ] && kill -TERM ${SETUP_NETWORK_PID}
</pre>
<p>This fails to kill all the decedent processes, I would suggest this change:</p>
<pre><code>diff --git a/dist/tools/ethos/start_network.sh b/dist/tools/ethos/start_network.sh
index 4f832a258..a457735e0 100755
--- a/dist/tools/ethos/start_network.sh
+++ b/dist/tools/ethos/start_network.sh
@@ -3,13 +3,13 @@
 ETHOS_DIR="$(dirname $(readlink -f $0))"
 
 cleanup() {
-    [ -n "${SETUP_NETWORK_PID}" ] && kill -TERM ${SETUP_NETWORK_PID}
     trap "" INT QUIT TERM EXIT
+    [ -n "${SETUP_NETWORK_GPID}" ] && kill -TERM -$SETUP_NETWORK_GPID
 }
 
 setup_network() {
     ${ETHOS_DIR}/setup_network.sh $1 $2 &
-    SETUP_NETWORK_PID=$!
+    SETUP_NETWORK_GPID=$(ps -o pgid= $! | grep -o '[0-9]*')
 }
 
 PORT=$1
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11840?email_source=notifications&email_token=ABE7WYECQLGE6J34TUFHJH3P73OKHA5CNFSM4IDU2R62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6VPXPI#pullrequestreview-262863805">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYHMCVWP6RYN7BEIDWTP73OKHANCNFSM4IDU2R6Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYC7M45SKROMJY5O3X3P73OKHA5CNFSM4IDU2R62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6VPXPI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11840?email_source=notifications\u0026email_token=ABE7WYECQLGE6J34TUFHJH3P73OKHA5CNFSM4IDU2R62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6VPXPI#pullrequestreview-262863805",
"url": "https://github.com/RIOT-OS/RIOT/pull/11840?email_source=notifications\u0026email_token=ABE7WYECQLGE6J34TUFHJH3P73OKHA5CNFSM4IDU2R62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6VPXPI#pullrequestreview-262863805",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>