<p><b>@maribu</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r306723456">cpu/atmega_common/periph/gpio.c</a>:</p>
<pre style='color:#555'>> +        if (enabled_pcints & 0x1) {
+            /* re-construct mask from pin number*/
+            uint8_t pin_mask = (1 << pin_num);
+            /* get pin from mapping (assumes 8 entries per bank!) */
+            gpio_t pin = pcint_mapping[ bank * 8 + pin_num ];
+            uint8_t port_value = (_SFR_MEM8(_pin_addr( pin )));
+            uint8_t pin_value = ((port_value & pin_mask) != 0);
+            uint8_t old_state = ((pcint_state[ bank ] & pin_mask) != 0);
+            gpio_isr_ctx_pcint_t *conf = &pcint_config[ bank * 8 + pin_num ];
+            if (old_state != pin_value) {
+                if (pin_value) {
+                    pcint_state[ bank ] |= (pin_mask);
+                }
+                else {
+                    pcint_state[ bank ] &= ~(pin_mask);
+                }
</pre>
<p>I fixed to typos above that made understanding what I meant impossible. It should now make sense.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11122?email_source=notifications&email_token=ABE7WYH2MELHRFWK5Y73ZLTQBAQRVA5CNFSM4G4LEPNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7MXLKY#discussion_r306723456">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYAT3JD5VJZBVZEKPR3QBAQRVANCNFSM4G4LEPNA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYF3KOB3TOEAF5PFIRLQBAQRVA5CNFSM4G4LEPNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7MXLKY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11122?email_source=notifications\u0026email_token=ABE7WYH2MELHRFWK5Y73ZLTQBAQRVA5CNFSM4G4LEPNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7MXLKY#discussion_r306723456",
"url": "https://github.com/RIOT-OS/RIOT/pull/11122?email_source=notifications\u0026email_token=ABE7WYH2MELHRFWK5Y73ZLTQBAQRVA5CNFSM4G4LEPNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7MXLKY#discussion_r306723456",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>