<p><b>@jia200x</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/8276#discussion_r307223295">sys/net/gnrc/netif/ieee802154/gnrc_netif_ieee802154.c</a>:</p>
<pre style='color:#555'>> @@ -90,7 +90,7 @@ static inline bool _already_received(gnrc_netif_t *netif,
 static gnrc_pktsnip_t *_recv(gnrc_netif_t *netif)
 {
     netdev_t *dev = netif->dev;
-    netdev_ieee802154_rx_info_t rx_info;
+    netdev_ieee802154_rx_info_t rx_info = { .crc_valid = 0 };
</pre>
<blockquote>
<p>It is also in general not save to assume the callee changes a value, so it should always be set if it is checked later. Just from a security perspective ;-).</p>
</blockquote>
<p>In that case I think <code>memset</code> is cleaner, considering there might be more rx_info stuff. This is independent to the fact the driver should always set it if it support automatic CRC calculation</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/8276?email_source=notifications&email_token=ABE7WYCDTNCT27J6MGGB533QBF5ANA5CNFSM4EI2JXP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7RPUSA#discussion_r307223295">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYHH7APG5W6MGHM37EDQBF5ANANCNFSM4EI2JXPQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYF4IPUMWDEU7IF6GB3QBF5ANA5CNFSM4EI2JXP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7RPUSA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/8276?email_source=notifications\u0026email_token=ABE7WYCDTNCT27J6MGGB533QBF5ANA5CNFSM4EI2JXP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7RPUSA#discussion_r307223295",
"url": "https://github.com/RIOT-OS/RIOT/pull/8276?email_source=notifications\u0026email_token=ABE7WYCDTNCT27J6MGGB533QBF5ANA5CNFSM4EI2JXP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7RPUSA#discussion_r307223295",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>