<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=241401" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cladmi">@cladmi</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=4679640" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kaspar030">@kaspar030</a> Since someone was asking for using <code>cpp</code> feature with ESP32, I tried to activate it. Principally, it is working when <code>pthread</code> module is used and <code>libstdc++</code> is linked.</p>
<p>However, to avoid that module <code>pthread</code> and <code>libstdc++</code> are used always even if they aren't needed, I tried to use them only, if feature <code>cpp</code> is required. Since there is no pseudomodule <code>cpp</code>, I just used <code>FEATURE_REQUIRED</code> in <code>cpu/esp32/Makefile.dep</code>:</p>
<pre><code>ifneq (,$(filter cpp,$(FEATURES_REQUIRED)))
    USEMODULE += pthread
    BASELIBS += -lstdc++
endif
</code></pre>
<p>Unfortunatly, static tests fail with</p>
<pre><code>Running './dist/tools/buildsystem_sanity_check/check.sh' x
Command output:
        Invalid build system patterns found by ./dist/tools/buildsystem_sanity_check/check.sh:
        Modules should not check the content of FEATURES_PROVIDED/_REQUIRED/OPTIONAL
                cpu/esp32/Makefile.dep:ifneq (,$(filter cpp,$(FEATURES_REQUIRED)))
</code></pre>
<p>How should I realize this dependency? Or should I add module <code>pthread</code> and link <code>libstdc++</code> always, even if they are not needed?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11922?email_source=notifications&email_token=ABE7WYCJGW6HPYYFEMOYKD3QBLBJBA5CNFSM4IHB4GCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24CCCY#issuecomment-515383563">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFKJYKBR53RB7WHJV3QBLBJBANCNFSM4IHB4GCA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYCWM3IGH2T3JO4T5OTQBLBJBA5CNFSM4IHB4GCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24CCCY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11922?email_source=notifications\u0026email_token=ABE7WYCJGW6HPYYFEMOYKD3QBLBJBA5CNFSM4IHB4GCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24CCCY#issuecomment-515383563",
"url": "https://github.com/RIOT-OS/RIOT/pull/11922?email_source=notifications\u0026email_token=ABE7WYCJGW6HPYYFEMOYKD3QBLBJBA5CNFSM4IHB4GCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24CCCY#issuecomment-515383563",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>